pg_fatal exits immediately and was leaving FILE* descriptors open on error paths in several client utilities (pgbench, pg_basebackup, pg_createsubscriber, pg_waldump, astreamer), risking buffered data loss and leaked handles.

• pgbench: close stdin/file on read error before pg_fatal.
• pg_basebackup: close manifest FILE* (and null it) on fwrite failure in streaming callbacks.
• pg_createsubscriber: close recovery config FILE* before fatal write failure.
• pg_waldump: close page dump FILE* before fatal write failure.
• fe_utils astreamer: close and null extracted file handle before fatal write failure.

Example:

if (fwrite(page, BLCKSZ, 1, file) != 1)
{
    int save_errno = errno;
    fclose(file);
    errno = save_errno;
    pg_fatal("could not write file \"%s\": %m", filename);
}

📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.